-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Keyboard arrow doesn't scroll #4282
Open
2 tasks done
Labels
accessibility
a11y
bug 🐛
Something doesn't work
component: data grid
This is the name of the generic UI component, not the React module!
regression
A bug, but worse
Comments
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
a11y
bug 🐛
Something doesn't work
component: data grid
This is the name of the generic UI component, not the React module!
regression
A bug, but worse
Duplicates
Latest version
Current behavior 😯
When using the Arrow keys, the new active cell is not visible
https://master--material-ui-x.netlify.app/components/data-grid/#commercial-version
Expected behavior 🤔
When using the Arrow keys, the new active cell should be visible (scroll if necessary).
https://0.0.0.0:3001/components/data-grid/#commercial-version
with
We can also see it behave correctly on the first demo of https://www.ag-grid.com/.
Steps to reproduce 🕹
Steps:
Context 🔦
It's a regression introduced in #2999 with the objective to fix #2508. I have found this by looking into #4280 in more detail. cc @m4theushw
preventScroll
so I'm always dubious when I see it..focus
is called when it shouldn't be called. Why is it called too often? Maybe because we useReact.useLayoutEffect
or because its dependencies change when they shouldn't.I have tested it again #2508 (comment). It seems that the root problem in #2508 was solved closer to the root later on (I suspect in #3718). Therefore we could revert #2999 to fix this GitHub issue with no downsides.
Your environment 🌎
MUI X v5.7.0.
Order ID 💳 (optional)
No response
The text was updated successfully, but these errors were encountered: