Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[playground] Wrong conversion between theme overrides vs sx prop #10514

Closed
1 task done
mnajdova opened this issue Sep 29, 2023 · 1 comment 路 Fixed by #10544
Closed
1 task done

[playground] Wrong conversion between theme overrides vs sx prop #10514

mnajdova opened this issue Sep 29, 2023 · 1 comment 路 Fixed by #10544
Assignees
@noraleonte
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@mnajdova
Copy link
Member

mnajdova commented Sep 29, 2023 •
edited by github-actions bot
Loading

Duplicates

  • I have searched the existing issues

Steps to reproduce 馃暪

Link to live example:

Steps:

  1. Change the border radius
  2. Switch to sx prop

Current behavior 馃槸

In the sx prop, the value of the border radius is much bigger, should be consider the slider a px like value and convert it accordingly when the sx prop is used?

Expected behavior 馃

I would not expect different look regardless of which method I copy for the style overrides

Context 馃敠

Screenshot 2023-09-29 at 13 10 48

vs

Screenshot 2023-09-29 at 13 04 49

Your environment 馃寧

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords:
@mnajdova mnajdova added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 29, 2023
@mnajdova mnajdova transferred this issue from mui/material-ui Sep 29, 2023
@mnajdova
Copy link
Member Author

Another thought would be great if there is a dashed grey border around the element that is being customized and maybe have a less drastic change in the styles when you switch the slot :)

@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Sep 29, 2023
@noraleonte noraleonte mentioned this issue Oct 2, 2023
Merged
1 task
@alexfauquette alexfauquette added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noraleonte noraleonte

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pickers] Improve customization playground examples noraleonte/mui-x
4 participants
@mnajdova @alexfauquette @noraleonte @zannager