Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix,feat: assume tty using environment variables #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aymanbagabas
Copy link
Collaborator

@aymanbagabas aymanbagabas commented Apr 14, 2023

Make Termenv aware of TERMENV_TTY and assume tty using environment
variables.

This also checks the actual value of CI instead of its length.

Fixes: 1111971 ("Don't run OSC queries on CI")

@muesli
Copy link
Owner

muesli commented Jul 5, 2023

That would however reintroduce issues with CIs like CircleCI.

Make Termenv aware of TERMENV_TTY and assume tty using environment
variables.

Fixes: 1111971 ("Don't run OSC queries on CI")
@aymanbagabas aymanbagabas changed the title fix: remove CI exception fix,feat: assume tty using environment variables Jul 5, 2023
@aymanbagabas
Copy link
Collaborator Author

That would however reintroduce issues with CIs like CircleCI.

Changed the PR to add a new TERMENV_TTY variable and check the value of CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants