Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The alternative editor does not work in Windows 11. #1082

Open
1 task done
pponec opened this issue Nov 13, 2023 · 2 comments
Open
1 task done

[Bug] The alternative editor does not work in Windows 11. #1082

pponec opened this issue Nov 13, 2023 · 2 comments
Labels

Comments

@pponec
Copy link

pponec commented Nov 13, 2023

Is there an existing issue for this?

  • I have searched the existing issues (including the closed ones)

Description

It looks like the configuration for the alternative editor in Windows 11 is not working properly. An error message appears when I try to edit a text:

image

The content of the commands.xml file:

image

Excaping spaces using backslashes didn't work for me either.

Steps to reproduce

  1. In the window pane, I select a text file.
  2. I'll press the F4 key.
  3. The error message below will be displayed. However, the application log did not contain any ERROR type entries.

Expected behavior

Opening the new window of the editor sublimetext. The Notepad++ editor showed the same behaviour.

Actual behavior

An error message appears when I try to edit a text.

Screenshots?

Error window (screenshot above)

muCommander version

Version information

muCommander
Version: 1.3.0
Build date: 2023/07/08
Build number: 057ec38

Java version

Java
Runtime version: 20.0.1
VM name: OpenJDK 64-Bit Server VM
VM version: 20.0.1+9
VM vendor: Eclipse Adoptium

Operating System type and version

OS
Name: Windows 11
Version: 10.0
Architecture: amd64

Relevant log output

No response

@pponec pponec added the bug label Nov 13, 2023
@ShayArtzi
Copy link
Contributor

Hi,

I just looked into this issue, and was able to reproduce on win10 as well (so looks like this is not related specifically to win11).

Based on the project's docs it seems the command was just defined incorrectly.

Try the following in your commands.xml file:

<?xml version="1.0" encoding="UTF-8"?>
<commands>
    <command alias="edit"  value="cmd /c start &quot;&quot; C:\\Program\ Files\\Sublime\ Text\\subl.exe $f"/>
</commands>

Here is a breakdown of the command:

cmd /c start &quot;&quot; C:\\Program\ Files\\Sublime\ Text\\subl.exe $f
  • cmd /c - start windows command line (and then terminate). see reference.
  • start - start a windows program ref.
  • &quot;&quot; - this is just "" - an empty title which is the first argument for the start command. We need to use &quot; since we are in an xml attribute which itself is surrounded by quotes.
  • C:\\Program\ Files\\Sublime\ Text\\subl.exe - sublime text's path - \ is an escape character we use before any space in the path, and in cases we need a literal \ we need to use \\.
  • $f - the actual file name from muCommander.

We might need to add this clarification to the documentation - @ahadas please LMK what you think...

@pponec
Copy link
Author

pponec commented Mar 14, 2024

Try the following in your commands.xml file:
...

Thank you for the explanation, the modified notation works great, changing the documentation would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants