Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling updates #65

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Tooling updates #65

merged 1 commit into from
Jan 6, 2020

Conversation

ZeeCoder
Copy link
Contributor

Fixes #64

@codecov
Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #65   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          34     33    -1     
=====================================
- Hits           34     33    -1
Impacted Files Coverage Δ
json-truncate.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0891c1a...fb93054. Read the comment docs.

@mrsteele
Copy link
Owner

I still think docs would need to be a thing. Any reason we can’t keep that using jsdoc?

@ZeeCoder
Copy link
Contributor Author

I think I removed it because it didn't work, but I'll double check.

@ZeeCoder
Copy link
Contributor Author

image
@mrsteele yeah it doesn't work in master, so I removed it assuming it wasn't needed.

@ZeeCoder
Copy link
Contributor Author

ZeeCoder commented Jan 2, 2020

Anything else I can do for you @mrsteele ?

@mrsteele
Copy link
Owner

mrsteele commented Jan 4, 2020

Sorry, it was holiday here so I was away from my email.

Can you add jsdoc https://www.npmjs.com/package/jsdoc

It should use the same syntax, but not support the newer ES stuff (which we dropped anyways).

Just don't wanna lose support of something we had before.

- Removed Babel, and moved tests as well as the main source to CommonJS,
  greatly simplyify tooling,
- The above resulted in an easier-to-bundle code for browsers as a side-effect,
- Removed esdoc, as it wasn't working anyway.
- Added the engines field in line with the travis tests.
- Replaced esdoc with jsdoc (As the former was not working anyways)
@ZeeCoder
Copy link
Contributor Author

ZeeCoder commented Jan 5, 2020

@mrsteele done 👌

@mrsteele mrsteele merged commit b48cac9 into mrsteele:master Jan 6, 2020
@ZeeCoder ZeeCoder deleted the tooling-updates branch January 6, 2020 15:18
@ZeeCoder
Copy link
Contributor Author

ZeeCoder commented Jan 6, 2020

@mrsteele when could I expect a release 🙏 ? Not familiar with how this semantic versioning works.

@mrsteele
Copy link
Owner

mrsteele commented Jan 6, 2020

Ah, it was supposed to include a feat: or fix: prefix in the commit. I'll manually push a release now.

@ZeeCoder
Copy link
Contributor Author

ZeeCoder commented Jan 6, 2020

I see, sorry I didn't realise.
Thanks man! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-register causing build issues
2 participants