Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty env vars #14

Closed
k-funk opened this issue Sep 2, 2016 · 4 comments · Fixed by #15
Closed

Allow empty env vars #14

k-funk opened this issue Sep 2, 2016 · 4 comments · Fixed by #15

Comments

@k-funk
Copy link

k-funk commented Sep 2, 2016

Getting this error: Error: Missing environment variable: CDN_HOST

webpack.config.js

...
  new DotenvPlugin({
    safe: false,
    systemvars: false
  })
...

.env

CDN_HOST=
OTHER_KEY1=ABC123

I know that I can just delete that empty key to make it work, but I'd rather dotenv-webpack just dump the vars in without any validation.
@mrsteele
Copy link
Owner

mrsteele commented Sep 2, 2016

Thanks for bringing this up. Let me test and see if I can reproduce / fix.

@mrsteele
Copy link
Owner

mrsteele commented Sep 2, 2016

Alright, definitely can reproduce let me do a little digging.

mrsteele pushed a commit that referenced this issue Sep 2, 2016
fix: Resolves an issue with empty variables and safe-mode disabled.
67be0ee 
Thanks @k-funk for the find.

closes #14
@mrsteele mrsteele mentioned this issue Sep 2, 2016
Merged
@mrsteele
Copy link
Owner

mrsteele commented Sep 2, 2016

1.2.1 is released to solve this problem.

Thank you @k-funk for bringing this to my attention. Let me know if you find anything else!

@k-funk
Copy link
Author

k-funk commented Sep 2, 2016

Thanks for the super quick fix!

@mkrause mkrause mentioned this issue Jun 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Resolves an issue with empty variables and safe-mode disabled. mrsteele/dotenv-webpack
2 participants
@k-funk @mrsteele