Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling for NUFFT operator #35

Open
chaithyagr opened this issue Oct 25, 2022 · 1 comment
Open

Scaling for NUFFT operator #35

chaithyagr opened this issue Oct 25, 2022 · 1 comment

Comments

@chaithyagr
Copy link

I feel it will help a lot to have scaling coded up inside the nufft operator, similar to https://github.com/chaithyagr/tfkbnufft/blob/da8de17bc5cb738d11150662d0876bec9efb54d8/tfkbnufft/nufft/fft_functions.py#L159 and https://github.com/chaithyagr/tfkbnufft/blob/da8de17bc5cb738d11150662d0876bec9efb54d8/tfkbnufft/nufft/fft_functions.py#L197 as it will help a lot to make sure that Op and AdjOp can match the scales for ortho case.

@jmontalt
Copy link
Member

jmontalt commented Nov 2, 2022

Yes, I agree that a scaling option might be useful. This is easy to implement as a simple wrapper in Python, but in the long term we could incorporate it into the kernel and potentially get some extra performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants