Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option that would allow us specify socks proxy #66

Open
danwdart opened this issue Jul 30, 2019 · 7 comments
Open

Add an option that would allow us specify socks proxy #66

danwdart opened this issue Jul 30, 2019 · 7 comments
Labels
awaiting-pr Issues I won't be working on myself feature-request

Comments

@danwdart
Copy link

Are there any plans to support socks?

Thanks

@mrkkrp
Copy link
Owner

mrkkrp commented Jul 30, 2019

Does http-client support them?

@danwdart
Copy link
Author

Via envs it looks like it does. snoyberg/http-client#262

@mrkkrp
Copy link
Owner

mrkkrp commented Jul 30, 2019

Since req is built on top of http-client, it should also support the feature is the same way. Do you think something is missing? If so, which form would it take in req?

@danwdart
Copy link
Author

Hmm, I thought since there was a httpConfigProxy :: Maybe Proxy field in HttpConfig, that that would suggest there could also be a httpConfigSocksProxy or that this field accepts another kind of Proxy (if you could make some other kind of proxy a Proxy)

@mrkkrp
Copy link
Owner

mrkkrp commented Jul 31, 2019

I'd accept a PR adding that.

@mrkkrp mrkkrp changed the title socks? Add an option that would allow us specify socks proxy Jul 31, 2019
@mrkkrp mrkkrp added the awaiting-pr Issues I won't be working on myself label Jul 31, 2019
@danwdart
Copy link
Author

Okay, awesome. I'll see what I can do.

@danwdart
Copy link
Author

Hmm, looks like that that's not the same way that the upstream package works, and I doubt you would want to have System.Environment and setEnv inside this package... I'll be looking for a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-pr Issues I won't be working on myself feature-request
Projects
None yet
Development

No branches or pull requests

2 participants