Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dap: await source map population before starting debugger #69

Closed
mrcjkb opened this issue Nov 19, 2023 · 1 comment
Closed

dap: await source map population before starting debugger #69

mrcjkb opened this issue Nov 19, 2023 · 1 comment

Comments

@mrcjkb
Copy link
Owner

mrcjkb commented Nov 19, 2023

          :thinking: 

The reason I use state is because the callback passed to vim.system is asynchronous in Neovim 0.10, so the source tables may not be ready by the time the user is presented with a choice of debuggables (but it should be by the time a choice is made). This makes the UI feel a bit more snappy (although I'll probably want to add some await calls before actually starting the debugger, to be on the safe side).

The way it's implemented right now - with only one state table - it's possible for multiple projects to interfere with each other. We should probably at least have a table with the workspace root as the keys to prevent this.

Originally posted by @mrcjkb in #64 (comment)

@mrcjkb
Copy link
Owner Author

mrcjkb commented Nov 27, 2023

Going with YAGNI on this.

@mrcjkb mrcjkb closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant