Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better options setting for session #2

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Better options setting for session #2

merged 1 commit into from
Dec 24, 2017

Conversation

mqp
Copy link
Contributor

@mqp mqp commented Dec 24, 2017 •
edited
Loading

Addresses #1.

Now each option gets its default independently, so if you do

new Session(sendFn, { timeoutMs: 15000 })

the session will still have the default keepaliveMs of 30000.

@mqp mqp merged commit f458546 into master Dec 24, 2017
@mqp mqp deleted the polite-options branch December 24, 2017 19:15
@mqp mqp mentioned this pull request Dec 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mqp