-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin no longer loads with latest libnice and janus-gateway #58
Comments
Looks like we need to accommodate these changes since API version 14: meetecho/janus-gateway#2060 Should be relatively straightforward. I will work on this soon. |
Was this ever done? |
No, thanks for the reminder. I see there have been a few new Janus releases since then, but no further plugin updates. I'll do it this week unless there's some unforeseen complication. |
this was the last plugin api change |
Ok. I'll pause my work on this then, was about to go through installing an older version just to accomodate this plugin. |
@mqp how's this looking? |
FYI, Janus 0.9.x (0.9.5 is the latest compatible) is not maintained anymore, Janus 0.10.x contains bugfixes for several CVEs, see meetecho/janus-gateway#2214 and meetecho/janus-gateway#2229 I don't know if it will be an issue with this plugin, but with Janus 0.10.5 and videoroom plugin, you need to specify the h264 profile now, profile id is "42e01f" (meetecho/janus-gateway#2330). I see this is specified in the new dialog sfu https://github.com/mozilla/dialog/blob/dc4e59cc775f88949043c145595bd7b08fd6fcb6/config.js#L115 but I didn't find it in the rust code. A bit off topic, I had a conversation with @kylebakerio about janus-plugin-sfu integration in a naf project here Hubs-Foundation/dialog#8 |
Timofey Martynov @feymartynov seems to be using janus-gateway 1da5aa226fb932c87fe70b35551057bd30c3713d (2020-09-28 11:02, post version v0.10.5) |
Yes, I successfully made the changes in janus-plugins-rs and janus-plugin-sfu to work with |
It's fully updated to be compatible with v0.10.9 now. |
Seems that janus-gateway > 0.9.5 no longer loads the janus-plugin-sfu module, complaining that API version 14 < 15:
I rolled back libnice and janus-gateway and was able to get it working again, but it seems some work may be needed to adapt it to the latest versions.
The text was updated successfully, but these errors were encountered: