-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arbitrary distance metrics #4
Labels
feature
For new features
Milestone
Comments
Hi @motiwari , do you currently recommend implementing custom distance metrics locally? Or shall I create a branch, code the distance metric in C++ as you suggested in the README and create a PR? |
@tanweer-mahdi the latter option is welcome and I'd be happy to review a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should have an easy way for users to incorporate their own dissimilarity metrics. Users should be able to write their dissimilarity metric in Python, which is then called via the C++ code.
User feedback suggests allowing users to pass the reference to the function that will compute distances. Asking the user to supply the O(n^2) distance matrix is of course infeasible.
This is a several-step task, including:
The text was updated successfully, but these errors were encountered: