Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with encoded urls #40

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Fix issue with encoded urls #40

merged 2 commits into from
Dec 16, 2021

Conversation

Siedlerchr
Copy link
Contributor

I noticed that my app was crashing when the url contains whitespaces

@Siedlerchr
Fix issue with encoded urls
ed4085b 
I noticed that my app was crashing when the url contains whitespaces
@mostafa-mansour1
Copy link
Owner

Kindly send me a sample url to check it
As this line was modified before and it’s make another issue

@Siedlerchr
Copy link
Contributor Author

Siedlerchr commented Oct 18, 2021 •
edited
Loading

Example: URL

https://raw.githubusercontent.com/Siedlerchr/testnestbug/master/arrow up with whitepspace.png
The problem is that the wrong variable is used, the encoded value is assigned to the url variable, but at that line the old one is used (myUrl)

@Siedlerchr
Update PreviewAnyFile.swift
5df369f 
Remove useless if condition. 
After I took a closer again, I come to the conclusion that the whole if condition is just a duplication and does not make any sense at that pint
@Siedlerchr
Copy link
Contributor Author

@mostafa-mansour1 It would be really great to have this fixed

@mostafa-mansour1 mostafa-mansour1 merged commit cc7d1dd into mostafa-mansour1:master Dec 16, 2021
@Siedlerchr Siedlerchr mentioned this pull request May 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @mostafa-mansour1