Log http2: stream closed as debug-level #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors occur as a result of the client closing the stream as we're still writing to it, which is a frequent and expected part of HTTP/2 operation, so we can safely log these at debug level.
domgoodwin
approved these changes
May 9, 2022
I don't think so off the top of my head - we can always come back and add them later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some internal reports of services logging warnings like "Couldn't send response body", with the underlying error being "http2: stream closed".
These errors occur as a result of the client closing the stream as we're still writing to it, which is a frequent and expected part of HTTP/2 operation, so we can safely log these at debug level.