Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(custom theme rename modal): automatically select input (@fehmer) #5487

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented Jun 11, 2024

Select the name text input on the Update custom theme modal so the user can directly type in the new name without deleting the old one

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jun 11, 2024
@fehmer fehmer marked this pull request as draft June 13, 2024 14:33
@fehmer
Copy link
Member Author

fehmer commented Jun 13, 2024

Make this option available on simple modals:

focusFirstInput(setting: true | "focusAndSelect" | undefined): void {

@fehmer fehmer force-pushed the feature/select-theme-name-on-rename branch from 0b72cd4 to ad84938 Compare June 17, 2024 14:14
@fehmer fehmer force-pushed the feature/select-theme-name-on-rename branch from ad84938 to 8fa0b3b Compare June 17, 2024 14:15
@fehmer fehmer marked this pull request as ready for review June 17, 2024 14:16
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec changed the title impr: select theme name on rename (@fehmer) impr(custom theme rename modal): automatically select input (@fehmer) Jun 17, 2024
@Miodec Miodec merged commit d733996 into master Jun 17, 2024
13 checks passed
@Miodec Miodec deleted the feature/select-theme-name-on-rename branch June 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants