-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
termMap has omissions #8
Comments
"HP_0025196 Increased total iron binding capacity@en" is not in term map. |
For the most part, we have not specified the language of the HPO labels, and probably just a few terms have the @en annotation. We could just remove the annotations from the OWL file or perhaps just programmaticaly delete them in the LOINC code. |
For now, we strip "@en" from the key when searching for the hpo term from the hash map. The best way is to address the difference of hp.owl (used for query) and hp.obo (used for generating <name, hpoTerm> map. |
Class "Model" builds a <name, HpoTerm> hash map. But it has omissions (e.g. Hypoglycemia is not in the final termMap, though it is a legit HPO term). The reason could be the filters used(?--why ignore terms that had >1 occurrence?). In addition, better use <id, HpoTerm> (?--name is NOT unique in ontology, id IS, at least theoretically).
The text was updated successfully, but these errors were encountered: