Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termMap has omissions #8

Closed
kingmanzhang opened this issue Jan 2, 2018 · 4 comments
Closed

termMap has omissions #8

kingmanzhang opened this issue Jan 2, 2018 · 4 comments

Comments

@kingmanzhang
Copy link
Member

Class "Model" builds a <name, HpoTerm> hash map. But it has omissions (e.g. Hypoglycemia is not in the final termMap, though it is a legit HPO term). The reason could be the filters used(?--why ignore terms that had >1 occurrence?). In addition, better use <id, HpoTerm> (?--name is NOT unique in ontology, id IS, at least theoretically).

@kingmanzhang
Copy link
Member Author

"HP_0025196 Increased total iron binding capacity@en" is not in term map.

@kingmanzhang kingmanzhang reopened this Jan 3, 2018
@kingmanzhang
Copy link
Member Author

kingmanzhang commented Jan 3, 2018

same for "HP_0025020 Elevated prostate-specific antigen level@en". Problem might be the last "@en".

-yes, removing "@en" solves the mapping issue.

@pnrobinson
Copy link
Member

For the most part, we have not specified the language of the HPO labels, and probably just a few terms have the @en annotation. We could just remove the annotations from the OWL file or perhaps just programmaticaly delete them in the LOINC code.

@kingmanzhang
Copy link
Member Author

For now, we strip "@en" from the key when searching for the hpo term from the hash map. The best way is to address the difference of hp.owl (used for query) and hp.obo (used for generating <name, hpoTerm> map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants