-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
until
should always return an Interval
#1551
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
.until(…)
is called on an invalidDatetime
instance, it returns the instance itself instead of an invalidInterval
.To Reproduce
It seems the bug was introduced in a2602aa#diff-5146f40a8c8111b14e5ab3407eff80c7a6d2f3c92a4bf4ccd4647bff32d47e38R1317-R1319 (although even back then, it did sometimes return an interval and sometimes a
Duration.invalid()
). Indiff()
and.diffNow()
this has been subsequently fixed during a reimplementation, butuntil
still exhibits the unexpected behaviour.The text was updated successfully, but these errors were encountered: