-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minified es6/luxon.min.js throws 'not a function or not iterable' for valid fromISO() #1229
Comments
Yeah, must be something up with the minifier |
In case you did want to switch back to Terser, I noticed a typo at: Line 55 in 4fe7be9
|
Hi @icambron, can I take up this issue? |
It might be worth investing whether microbundle is a viable option. |
If we do go down the route of adding yet another place where the version string lives, let's be sure to update the release script to check that this additional location is the same as the others. There is already tooling to check that the version in the code matches the one in package.json. |
Describe the bug
DateTime.fromISO('2019-01-01T05:00:00.000')
Note that this runs perfectly fine with the non-minified es6 version.
To Reproduce
Please share a minimal code example that triggers the problem:
Actual vs Expected behavior
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: