Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accel LPF Assignement #4

Open
KevinMechler opened this issue Nov 26, 2021 · 0 comments
Open

Accel LPF Assignement #4

KevinMechler opened this issue Nov 26, 2021 · 0 comments

Comments

@KevinMechler
Copy link

Hello. Thank you for writing this driver. I'm currently adapting it to be useful for a different IMU but STM32 friendly.

void icm20948_accel_low_pass_filter(uint8_t config)
{
	uint8_t new_val = read_single_icm20948_reg(ub_2, B2_ACCEL_CONFIG);
	new_val |= config << 3;

	write_single_icm20948_reg(ub_2, B2_GYRO_CONFIG_1, new_val);
}

I wanted to point out that the registers here do not line up. I think this is a simple typo, and it likely will not have much of an effect, but it would likely be a good idea to fix this before it affects someone's project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant