-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find_package(Coarray REQUIRED) breaks parallel caf build #7
Comments
I began the transition to a more traditional, "directory-per-chapter" code organizations, and moving away from organization by git tag, see https://github.com/modern-fortran/tsunami/tree/refactor-by-chapter. I thought organizing by git tags would be useful (and I really enjoyed it in another book that inspired me to take that path), however it's become a nightmare to manage with the shifting around of chapters and what not. Also, based on 2nd external review, not many readers appreciate this style. Many also find friction with cmake so we'll be likely moving away from that as well, back to simpler, make-based builds. Keeping this open for now, but will likely become a non-issue very soon |
Clean up done and now merged in master. Closing. |
@scivision Unfortunately, only tonight I realized that recent updates to CMakeLists.txt broke my local parallel build.
I didn't catch this before because it seemed to build successfully, but I haven't been paying attention to cmake output -- it's been building in
-fcoarray=single
mode exclusively.If I do specify a path to my OpenCoarrays install dir, the cmake config fails altogether.
If I comment out
find_package(Coarray REQUIRED)
in CMakeLists.txt, then I can successfully configure and build in the old way:I expect this issue is something trivial as it works for you and it does on Travis. Let me know if you have an idea, otherwise I currently don't have the bandwidth to debug this.
The text was updated successfully, but these errors were encountered: