-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy LegacyMockInterface #1224
Labels
Milestone
Comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This might need splitting further. Ideally any "internal" methods, i.e. those we use to manage and run the doubles, shouldn't be exposed in the interface.
It would be nice to update the return types (either in the code itself or in the PHPStorm Meta), so that it's clear that the various factory methods return a union type of the class the user specifies, along with the methods mockery makes available to them, but not the internal rubbish like
mockery_getContainer
etc.With:
I currently see:
The
MockInterface extends LegacyMockInterface
might still be useful to keep (see #861), but it's messy, and it might be time to cut those people loose, or provide a better alternative.The text was updated successfully, but these errors were encountered: