-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automate code formatting #2980
Comments
A thing that will happen if we do this is pretty much every file will be touched, because there's no way to disable some of the disagreements between prettier and semistandard. |
to be more specific, prettier will remove the spaces after the fwiw, I'm cool with using a more unopinionated formatter if one exists. the killer feature here for Mocha is automatic application of a style--not the style itself--but prettier conflates the two. that's fine for FB and solves their problem, but it's not necessarily Mocha's problem. |
(because Mocha is not thousands of javascript projects, it's just one) |
I wouldn't at all mind losing the spaced between I believe XO is designed to work better with Prettier and to be less stubbornly opinionated, if I heard correctly in the past. |
Drive-by: it looks this issue was addressed by #3344? |
@bakkot totally missed it, thanks. |
I've played with prettier a bit, and it seems like a reasonable solution (especially when combined with husky) to enforce a code style across the codebase.
This should prevent nitpicks about style in PRs.
We could also likely make the pre-commit hook run
eslint --fix
.semver-patch
because it should have no impact upon API or program output.The text was updated successfully, but these errors were encountered: