Port fwctl over from bhyve #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2017 12:34
Pristine versions not yet tied into the build. Signed-off-by: Ian Campbell <[email protected]>
Required some adjusting of includes but mostly fixing up a slew of things relating to our much stricter compiler warnings (lots of unsigned -> signed conversions, some alignment increases, switches over enums missing cases). Signed-off-by: Ian Campbell <[email protected]>
rn
approved these changes
Oct 20, 2017
|
LGTM too - tested the binary and it solves the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the UEFI firmware to correctly detect the number of vcpus. Without this the guest only sees 1 vcpu regardless of the use of
-cbecause the firmware tables (ACPI) won't be setup correctly.The first commit simply imports the pristine files from FreeBSD, the second commit is the interesting one I guess.