You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Bringing back an old issue #2841
![image](https://private-user-images.githubusercontent.com/14803931/337215444-9e8e0b77-855b-416b-a427-fd122b3cb2aa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIwMDk1MTAsIm5iZiI6MTcyMjAwOTIxMCwicGF0aCI6Ii8xNDgwMzkzMS8zMzcyMTU0NDQtOWU4ZTBiNzctODU1Yi00MTZiLWE0MjctZmQxMjJiM2NiMmFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI2VDE1NTMzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThiNzY1NGU4ZTFlYzkwODYwNjA5YzcyOTAzOTk1NWNkMDE1MjA4Mzk0ZGZmZTM2ODQyNTJkNTM0NDU3NzcyNTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._4mVaa-AnpcP5xhdcCcu86yxiShc4DWrqIXPhtgAQl8)
I think it's possible to make the original class immutable by doing this
still pass all unit tests
* fails only one unit test in disposeOnUnmount.test
Beta Was this translation helpful? Give feedback.
All reactions