Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureWarning in latest pytorch release #192

Closed
scott-huberty opened this issue Jul 25, 2024 · 0 comments · Fixed by #193
Closed

FutureWarning in latest pytorch release #192

scott-huberty opened this issue Jul 25, 2024 · 0 comments · Fixed by #193

Comments

@scott-huberty
Copy link
Contributor

I started seeing this in the CI's of another project I work on: https://github.com/lina-usc/pylossless/actions/runs/10085318831/job/27886113913

Looks like PyTorch 2.4 was just released today, and they throw a FutureWarning for an upcoming API change (see changelog ):

User warning when using torch.load with default weights_only=False value (pytorch/pytorch#129239, pytorch/pytorch#129396, pytorch/pytorch#129509).
A warning is now raised if the weights_only value is not specified during a call to torch.load, encouraging users to
adopt the safest practice when loading weights.

It appears that the offending line is here:

https://github.com/mne-tools/mne-icalabel/blob/1c36710dac5600942d976ade0c2ee43afef2e368/mne_icalabel/iclabel/network/torch.py#L201C1-L202C1

I can open up a PR in the morning unless someone else beats me to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant