Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadData() to KNNClassifier that enables user to load dataset from raw data instead of file #284

Closed
champierre opened this issue Feb 16, 2019 · 1 comment

Comments

@champierre
Copy link
Contributor

champierre commented Feb 16, 2019

Nature of issue?

  • Existing feature enhancement

Existing Feature Enhancement details:

I created a machine learning app using ml5.js KNNClassifier and wanted a feature that enables the user to upload the dataset from <INPUT type="file"> tag like the following capture image.

2019-02-16 18 18 31

With load(), file path needs to be provided, but you cannot get file path when you upload from file tag. So, I added to my customized ml5.js, loadData() that enables user to load dataset from raw data. By combining this method and <INPUT type="file"> tag, I could give a way for user to upload dataset file.

I think this is common user case, so I opened PR #279 so that other users can use this feature.

@joeyklee
Copy link
Contributor

This seems resolved with #279. I will close for now. Thanks so much @champierre !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants