Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New license #1203

Closed
Aspie96 opened this issue May 13, 2021 · 2 comments · Fixed by #1233
Closed

New license #1203

Aspie96 opened this issue May 13, 2021 · 2 comments · Fixed by #1233
Labels
bug general

Comments

@Aspie96
Copy link

Aspie96 commented May 13, 2021

I am quite confused.

The README mentions the new license:

Read our ml5.js Code of Conduct and software licence here!

But the repo still contains only the old one.

While if there are contributions the old license must of course be preserved to avoid a VCR kind of fiasco, it's not clear to me which license applies.

Is it the MIT license, which is what GitHub detects and which is in the LICENSE file, a standard way of identifying the license?

Or is it the one mentioned in the document?
@bomanimc
Copy link
Member

Great point @Aspie96!

@mwweinberg: What do you suggest we do to address this? Would it be best to copy and paste the ml5.js License into this repository, or would it be sufficient to write something like "Please see our license and code of conduct..." in the LICENSE file.

Presumably, we'd probably want to generalize this approach to all of our ml5.js repositories.

@mwweinberg
Copy link

That's a fine point. It would be best to copy and paste the license itself. When that happens, we should probably change the header that reads:

Version 1.0 of the ml5.js license was adopted and last updated on May 10, 2021. It applies to the ml5.js library as of May 20,2021. You can read the blog post announcing and explaining the development of the license here.

to read:

Version 1.0 of the ml5.js license was adopted and last updated on May 10, 2021. It applies to all contributions to the ml5.js library as of May 20,2021. Contributions prior to that date are licensed under the MIT license. You can read the blog post announcing and explaining the development of the license here.

@bomanimc bomanimc mentioned this issue Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy over ml5.js license from Code-of-Conduct repo ml5js/ml5-library
3 participants
@mwweinberg @bomanimc @Aspie96