Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentiment: Incorrect case (typo) in code usage example #1143

Closed
alextyner opened this issue Feb 9, 2021 · 1 comment · Fixed by #1144
Closed

Sentiment: Incorrect case (typo) in code usage example #1143

alextyner opened this issue Feb 9, 2021 · 1 comment · Fixed by #1144

Comments

@alextyner
Copy link

alextyner commented Feb 9, 2021

Dear ml5 community,

I'm submitting a new issue. Please see the details below.

→ Step 1: Describe the issue 📝

In the file ml5-library/docs/reference/sentiment.md, this usage code is present:

const magic = ml5.Sentiment(model, ?callback);

Here, Sentiment should be lowercase: sentiment instead.

And, as much as I like the fun of it, consider also changing the variable name magic to reflect what it references (perhaps sentiment like the other example code on the page).

@alextyner alextyner changed the title Sentiment: Incorrect case in code usage example Sentiment: Incorrect case (typo) in code usage example Feb 9, 2021
@bomanimc
Copy link
Member

Agreed on both points! Thanks for filing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants