Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should Misskey avoid external <iframe> for the mascot-web? #14010

Open
KisaragiEffective opened this issue Jun 15, 2024 · 15 comments
Open

should Misskey avoid external <iframe> for the mascot-web? #14010

KisaragiEffective opened this issue Jun 15, 2024 · 15 comments
Labels
💬Discussion Being discussed or needs discussion

Comments

@KisaragiEffective
Copy link
Collaborator

          you can also add external iframe on your list (show in classic UI view)

Sans titre

Originally posted by @Albirew in #7043 (comment)

(個人的な意見: これが問題になることってあるだろうか?)

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jun 15, 2024

これが問題になることってあるだろうか?

(misskey-devのorgが乗っ取られたりGitHub Pagesがサ終したりするようなことがない限り)特にないと思う

強いて言えばCSPの設定がまずいと当該フレームが表示されないくらい

@KisaragiEffective
Copy link
Collaborator Author

cc #9863 ?

@kakkokari-gtyih
Copy link
Contributor

別にそれについてもmascot-webのフレームを通すようにすればいいだけの話なのでこれ以上何ってこともないと思うけど

@KisaragiEffective
Copy link
Collaborator Author

ならこれはcloseしても良いやつかな

@KisaragiEffective
Copy link
Collaborator Author

閉じる

@KisaragiEffective KisaragiEffective closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
@Albirew
Copy link

Albirew commented Jun 15, 2024

my point was we should not need to depend on 3rd party website for content.
For the same reason as why external CDN are disappearing: privacy.

つまり言いたかったのはコンテンツに第三者は出来る限りに頼るべきじゃ無い。
CDNはどんどん無くなると同じ意味で:プライバシー。

@KisaragiEffective
Copy link
Collaborator Author

@syuilo said in #8901 (comment):

このリポジトリに入れたからと言って強制的にAGPLになるわけではないから入れても良さそう
でもあんまりバイナリ入れたくない

@Albirew
Copy link

Albirew commented Jun 15, 2024

oh, ok.
following question is completely optional as syuilo's answer is fine in it's own.

would it be possible to add an option (either in .config/default.yml or admin panel) that would download and store it locally if enabled and files are not already present?

@kakkokari-gtyih
Copy link
Contributor

would it be possible to add an option (either in .config/default.yml or admin panel) that would download and store it locally if enabled and files are not already present?

for ai-chan mascot, it's impossible because of Live2D's commercial license

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jun 16, 2024

hosting live2d-related thing by yourself requires you to comply live2d license and might require you to pay license fee

https://www.live2d.com/en/sdk/license/

@Albirew
Copy link

Albirew commented Jun 16, 2024

Ah, i got it.
I was thinking only as a non-profit entity or as the Misskey-dev's point of view, but if companies want to use Misskey, they would have to pay live2d for hosted content.
Issue can be re-closed.
PS: @KisaragiEffective can you rename issue to "mascot-web external iframe hosting" ? so people can better find this issue when searching. Thanks.

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jun 16, 2024

if companies want to use Misskey, they would have to pay live2d for hosted content

yes, if the mascot is self-hosted. Since Live2D's proprietary code is NOT included in the misskey at this time, you don't have to pay to Live2D inc.

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jun 16, 2024

(off-topic) Live2Dを利用して製作されたmisskey-devのサイトをiframeで埋め込んだ場合ライセンス費用(どこに請求されるのか、売上金の計算はどうするのか)はどうなるのかなどについて確認しておいたほうがいいかも?

@KisaragiEffective
Copy link
Collaborator Author

off-topic: 埋め込んだ場合、運用元の売り上げや寄付金を受け取る規模が大きいとライセンス料が発生しそう

@KisaragiEffective KisaragiEffective changed the title you can also add external iframe on your list (show in classic UI view) should Misskey avoid external <iframe> for the mascot-web? Jun 16, 2024
@KisaragiEffective KisaragiEffective added the 💬Discussion Being discussed or needs discussion label Jun 16, 2024
@KisaragiEffective
Copy link
Collaborator Author

@Albirew wrote:

PS: @KisaragiEffective can you rename issue to "mascot-web external iframe hosting" ? so people can better find this issue when searching. Thanks.

Indeed, done 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬Discussion Being discussed or needs discussion
Projects
None yet
Development

No branches or pull requests

3 participants