Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Object Storage ignores meta.objectStorageS3ForcePathStyle while constructing the file-URL #13887

Open
1 task
Kurty00 opened this issue May 26, 2024 · 1 comment
Labels
鈿狅笍bug? This might be a bug

Comments

@Kurty00
Copy link

Kurty00 commented May 26, 2024

馃挕 Summary

I'm using minio as a s3 compatible storage backend. When uploading a file to the drive, the bucket name is not included in the URL despite the s3ForcePathStyle toggle being enabled.
When I upload a file, the resulting URL on my instance is https://[host]/[prefix]/[blob] instead of https://[host]/[bucket]/[prefix]/[blob]

馃グ Expected Behavior

The file that is uploaded should have the correct URL in Misskey.

馃が Actual Behavior

The URL does not include the bucket name.

馃摑 Steps to Reproduce

  1. Configure objectstorage with minio and enable s3ForcePathStyle
  2. Upload a file to the drive.
  3. The resulting file will not be loaded as Misskey constructed a wrong URL.

馃捇 Frontend Environment

* Browser: Firefox 126.0
* Server URL: mastodon.nexus
* Sharkey: 2024.3.3

馃洶 Backend Environment (for server admin)

* Installation Method or Hosting Service: docker compose
* Misskey: sharkey: 2024.3.3
* PostgreSQL: docker.io/postgres:12.2-alpine
* Redis: docker.io/redis:7.0-alpine
* OS and Architecture: Debian amd64

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@Kurty00 Kurty00 added the 鈿狅笍bug? This might be a bug label May 26, 2024
@Kurty00
Copy link
Author

Kurty00 commented Jun 23, 2024

I've also opened an issue on the sharkey repo.

https://activitypub.software/TransFem-org/Sharkey/-/issues/508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
鈿狅笍bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

1 participant