Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tidal #33

Open
MoroseCorpse opened this issue Feb 2, 2021 · 2 comments
Open

Add support for Tidal #33

MoroseCorpse opened this issue Feb 2, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MoroseCorpse
Copy link

MoroseCorpse commented Feb 2, 2021

I have a suggestion that you could add. It would be very nice if your tool would also support the streaming service Tidal, as this is also used by a lot of people

@miraclx miraclx added the enhancement New feature or request label Feb 2, 2021
@miraclx
Copy link
Owner

miraclx commented Feb 2, 2021

Great idea, I've just recently discovered https://github.com/yaronzz/Tidal-Media-Downloader which might be a good alternative for now. Although freyr could certainly extend itself to support tidal.

Currently, the best API interface to tidal that I've seen so far is https://github.com/tamland/python-tidal which is in python.

So, freyr would need to complete #21 for it to support this. Just like in #6.

However, that library directly requires users to provide private credentials like their username and password which, I can assume, some users might not be comfortable with.

This should "preferrably" be an oauth2 login.

So, until tehkillerbee/mopidy-tidal#27 is merged into python-tidal (as suggested here tehkillerbee/mopidy-tidal#27 (comment)), freyr would hold back supporting this

@miraclx
Copy link
Owner

miraclx commented Feb 2, 2021

Another thing to note is freyr doesn't currently support downloading feeds from non-youtube sources, although technically, it's modular enough to easily support it. But the postprocessor isn't configured to output anything other than m4a.

Would gladly welcome any PRs to work on this.

@miraclx miraclx added the good first issue Good for newcomers label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants