Numpy2.0 #134
Merged
Numpy2.0 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, non supported backend would failed afterwards.
Closed
7 tasks
chaithyagr
reviewed
Jun 21, 2024
Comment on lines
+112
to
+117
| if wrt_data or wrt_traj: | ||
| if isinstance(operator, FourierOperatorBase): | ||
| operator = operator.make_autograd(wrt_data, wrt_traj) | ||
| else: | ||
| # instance will be created later | ||
| operator = partial(operator.with_autograd, wrt_data, wrt_traj) |
There was a problem hiding this comment.
no, but this is a fix for something else (that I thought was already merge).
chaithyagr
reviewed
Jun 21, 2024
.github/workflows/test-ci.yml
Outdated
| @@ -53,6 +53,7 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| sudo apt install -y libnfft3-dev | |||
| python -m pip install numpy<2.0.0 | |||
There was a problem hiding this comment.
shouldnt we update in pyproject.toml? Like is it a test issue or lack of compatibility?
There was a problem hiding this comment.
It's more complicated than that, some backend requires numpy<2.0, other don't care
There was a problem hiding this comment.
Maybe we document the problem in issue and tag it here? That way we know what needs a fix.. Is the pipeline broken currently?
chaithyagr
reviewed
Jun 24, 2024
|
Turns out we needed another release with numpy>2.0 for pynfft2. I have added required stuff in pyproject.toml, also CI. @paquiteau ready to review and merge when green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 got released, some nufft backend are broken, this fixes them in the CI.