Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the trajectory and DCp when self.samples is updated #132

Closed
6 tasks done
chaithyagr opened this issue Jun 21, 2024 · 2 comments
Closed
6 tasks done

Update the trajectory and DCp when self.samples is updated #132

chaithyagr opened this issue Jun 21, 2024 · 2 comments
Assignees

Comments

@chaithyagr
Copy link
Member

chaithyagr commented Jun 21, 2024

This issue will track a bunch of features needed for learning k-space sampling trajectories.

For now, what we need is:

  • self.samples property setter to have update the corresponding plans to update the trajectory in respective raw_op for each backend.
    • This is doable in finufft and cufinufft easily as there is a set_pts function. @alineyyy will handle a PR for it. @alineyyy for other backends, please add an error for now. This can be done by having error raised in the main setter in the base class.
    • For gpuNUFFT, we need some update on gpuNUFFT side. @chaithyagr will handle this. Add support for updating points with gpuNUFFT #133
    • @paquiteau can you detail more about other backends and if want to support for them? (Most dont have autodiff wrt to trajectory anyway).
  • Update the density compensators accordingly. This is a bit complicated as it means we need to save how the density was estimated. @paquiteau lets discuss about this and @Lenoush can you please work on it?
  • A bunch of tests overall to test this. This is fairly straightforward. But its good sanity tests Add support for updating points with gpuNUFFT #133
@chaithyagr
Copy link
Member Author

Please add on if theres anything I missed. Generally I would also prefer sensitivity maps to change. But thats a different ballgame as the sensitivity maps need to anyway change with k-space data also.

@chaithyagr
Copy link
Member Author

All of this is handeled now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants