Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case method == True in compute_density() in base.py #125

Closed
Lenoush opened this issue Jun 5, 2024 · 1 comment · Fixed by #130
Closed

Add case method == True in compute_density() in base.py #125

Lenoush opened this issue Jun 5, 2024 · 1 comment · Fixed by #130
Assignees
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@Lenoush
Copy link
Contributor

Lenoush commented Jun 5, 2024

here method can also be a bool :

method: str or callable or array or dict
The method to use to compute the density compensation.
If a string, the method should be registered in the density registry.
If a callable, it should take the samples and the shape as input.
If a dict, it should have a key 'name', to determine which method to use.
other items will be used as kwargs.
If an array, it should be of shape (Nsamples,) and will be used as is.

and here :

if not method:
self.density = None
return None

if method :
if nufft.cls has method pipe:
method = "pipe"

@paquiteau
Copy link
Member

Seems to be a reasonable addition, I guess you can handle it :)

@paquiteau paquiteau added feature request New feature or request good first issue Good for newcomers labels Jun 5, 2024
@Lenoush Lenoush linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants