Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorflow-NUFFT density is not density_compensation #109

Closed
chaithyagr opened this issue May 22, 2024 · 0 comments · Fixed by #114
Closed

Tensorflow-NUFFT density is not density_compensation #109

chaithyagr opened this issue May 22, 2024 · 0 comments · Fixed by #114
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@chaithyagr
Copy link
Member

if density is True:
self.density = tfmri.estimate_density(
samples, shape, method="pipe", max_iter=15
)

Here, estimate_density just estimates the density, not the density_compensators. What we need is a reciprocal of this values.

All we need to do is to change this line to:
tf.math.reciprocal_no_nan(tfmri.estimate_density(
samples, shape, method="pipe", max_iter=15
))

Also, some tests on this would be helpful.

@chaithyagr chaithyagr added bug Something isn't working good first issue Good for newcomers labels May 22, 2024
@Lenoush Lenoush linked a pull request May 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants