Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simple example to showcase autodiff #104

Open
1 of 4 tasks
chaithyagr opened this issue May 16, 2024 · 7 comments · Fixed by #167
Open
1 of 4 tasks

A simple example to showcase autodiff #104

chaithyagr opened this issue May 16, 2024 · 7 comments · Fixed by #167
Assignees
Labels
good first issue Good for newcomers

Comments

@chaithyagr
Copy link
Member

chaithyagr commented May 16, 2024

We could have possibly the following examples:

  • A simple U-Net (pulled from fastMRI dataset possibly), trained? @Lenoush can you handle this in your free time?
  • A network built with DeepInv library for some already preset reconstruction (PnP possibly?) @matthieutrs can you handle this this in your free time? I think you can also have something basic passed to @Lenoush and she can work on it forward.
  • A simple example where we could learn the trajectory possibly? @alineyyy can you handle this in your free time? Have a trajectory learner example and reform the documentation build flow #167
  • Add additional support for learning a sampling pattern in 2D with straight line readouts. Perhaps we can do it while supporting stackNUFFT on torch?
@chaithyagr chaithyagr added the good first issue Good for newcomers label May 16, 2024
@paquiteau
Copy link
Member

Beware, there is also autodiff for the image/k-space data (the one that is only currently supported) This could also be show cased.

@chaithyagr
Copy link
Member Author

I really seemed to have clicked open issue too soon. I had written so much more xD. Lemme update

@chaithyagr
Copy link
Member Author

@AsmaTANABEN , can you have a look at the notebook shared in mattermost and see if we can get this on mri-nufft?

@chaithyagr
Copy link
Member Author

Reopening as it got closed by mistake :P

@chaithyagr
Copy link
Member Author

I added that we could have additional support for learning a sampling pattern in 2D with straight line readouts.

Perhaps we can do it while supporting stackNUFFT on torch? @paquiteau is this possible? Can we pass the backprop gradients through the stacked NUFFT from the internal plane NUFFT?

@chaithyagr
Copy link
Member Author

On second thoughts, we would need 176 2D NUFFT then num_samples number of FFTs, I think a simple straightforward 3D NUFFT can be easier. @paquiteau to comment. I think in your usecase for fMRI it is more useful.

@paquiteau
Copy link
Member

after rethinking about it, stacked nufft does not have autodiff wrt to trajectory. It does support the autodiff wrt to data however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants