Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save session.id in session #53

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Passwordless::Session#valid_session?
  • Loading branch information
JoeSouthan committed May 7, 2019
commit 509101202fdd9f970169a5f5a845a61843e598e0
4 changes: 4 additions & 0 deletions app/models/passwordless/session.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ def claimed?
!!claimed_at
end

def valid_session?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session.valid_session? has a double session. Let's rename to session.valid? ?

!timed_out? && !expired?
end

private

def set_defaults
Expand Down
12 changes: 12 additions & 0 deletions test/models/passwordless/session_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,17 @@ def call(_session)
claimed_session.claim!
end
end

test "valid_session? - valid session" do
valid_session = create_session

assert_equal valid_session.valid_session?, true
end

test "valid_session? - invalid session" do
invalid_session = create_session timeout_at: 2.years.ago, expires_at: 2.years.ago

assert_equal invalid_session.valid_session?, false
end
end
end