Add functionality to mark tokens as claimed to prevent re-use #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 25, 2019
mikker
requested changes
Apr 26, 2019
|
Hi @mikker! Thanks for having a look over the PR. There is the possibility of a bad actor intercepting the token from the email and using it to initiate their own session, the token should immediately be claimed to prevent this. Expiry goes some way to prevent this, but if it's still within the expiry time you can log back in. |
- Reformat readme - claimed -> claimed_at - Supporting tests
7ba51ba
to
41107d7
Compare
Since claimed_at no longer has constraints, there is no need for a HA migration
|
@mikker I've removed the section on HA migrations as there are no column constraints/indices being created. |
mikker
approved these changes
Apr 30, 2019
|
💙💚💛💜❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help improve the security and one time nature of the links generated by passwordless, I’ve put together a configuration option to expire tokens after a login attempt.
Let me know what you think.