-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
troubles upgrading to 1.0.0 #168
Comments
Thank you! This sounds like a genuine bug. I'll look into it when I have a little time to spare |
I am experiencing these issues as well. The fix for the paths missing the _ is easy enough (happy to submit a pr). However if you set |
Made a PR. I think it'll fix your problems. If you can, please give it a go and let me know if it fixes your problems. |
first of all, congrats on releasing
1.0.0
! 🥳 I really love the new "token input" form.I just tried upgrading my app to 1.0.0, and faced a few challenges:
Now,
![Screenshot 2023-10-15 at 13 52 02](https://private-user-images.githubusercontent.com/13472945/275323722-4f45687c-9eef-4fae-8b8c-b5e11dd9cf01.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMzkzNDQsIm5iZiI6MTcyMTMzOTA0NCwicGF0aCI6Ii8xMzQ3Mjk0NS8yNzUzMjM3MjItNGY0NTY4N2MtOWVlZi00ZmFlLThiOGMtYjVlMTFkZDljZjAxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDIxNDQwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzZjI3OWMwNDBkYjBmY2QzNzVjYzkzZjYwYTVkMDkyNjE1NmNhNzZhMDAwNTQ0ZWI2YzA4ZmFlNDI1NDY3YzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iGAfDvQ2M_m3rS9edaLFoGHzokbKpt4_xrFru6sodpA)
passwordless_for :users, at: '/', as: :auth
generates:
(it loses the
_
)I remove the
![Screenshot 2023-10-15 at 13 53 07](https://private-user-images.githubusercontent.com/13472945/275323774-05d30e40-342e-4a8f-87c2-6781dfc94e24.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMzkzNDQsIm5iZiI6MTcyMTMzOTA0NCwicGF0aCI6Ii8xMzQ3Mjk0NS8yNzUzMjM3NzQtMDVkMzBlNDAtMzQyZS00YThmLTg3YzItNjc4MWRmYzk0ZTI0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDIxNDQwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlmNjU0MWM1YzU0MTU3OTgwNTBmYTY2MjY0NzkyM2RhMWIwOGU4YTNhMzE4Njg4ZjZjMWQ0MGE4YWZjZDgxOWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.myc9weCU200a5Tsy9-1Eb_8qtmBwMHNFblfso_P9jaA)
as: :auth
, and change it topasswordless_for :users, at: '/'
. Now the routes look like this:However now the tests are failing on
passwordless_sign_in(@user)
:The text was updated successfully, but these errors were encountered: