Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troubles upgrading to 1.0.0 #168

Closed
yshmarov opened this issue Oct 15, 2023 · 3 comments · Fixed by #174
Closed

troubles upgrading to 1.0.0 #168

yshmarov opened this issue Oct 15, 2023 · 3 comments · Fixed by #174

Comments

@yshmarov
Copy link
Contributor

yshmarov commented Oct 15, 2023

first of all, congrats on releasing 1.0.0! 🥳 I really love the new "token input" form.

I just tried upgrading my app to 1.0.0, and faced a few challenges:

Now, passwordless_for :users, at: '/', as: :auth
generates:
Screenshot 2023-10-15 at 13 52 02

(it loses the _)

I remove the as: :auth, and change it to passwordless_for :users, at: '/'. Now the routes look like this:
Screenshot 2023-10-15 at 13 53 07

However now the tests are failing on passwordless_sign_in(@user):

Screenshot 2023-10-15 at 13 53 54
@mikker
Copy link
Owner

mikker commented Oct 15, 2023

Thank you! This sounds like a genuine bug. I'll look into it when I have a little time to spare

@jpatters
Copy link

I am experiencing these issues as well. The fix for the paths missing the _ is easy enough (happy to submit a pr). However if you set as: to something other than :users it still generates the urls with users in them. This seems to be a deeper rooted issue.
So as far as I can tell, as: just doesn't work.

@mikker
Copy link
Owner

mikker commented Oct 21, 2023

Made a PR. I think it'll fix your problems. If you can, please give it a go and let me know if it fixes your problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants