-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7 redirection error due to allow_other_host option not being true #140
Comments
@mikker what do you think about this idea? |
Sounds okay 👍 PR welcome |
@mikker After taking a closer look at the source code, and seeing how I'm the only person to raise this issue, I think it might be best to keep things simple by adding the following config setting.
This would make it so the host application could easily specify I'll probably noodle on this today. What I proposed is fine, but it's probably overkill unless others start facing similar or more complex redirection issues. |
I'm working with a multi-tenant app, and there is a need move users between subdomains. The app running with Rails 7. There is a
redirect_to
call in thepasswordless
source that does not use theallow_other_host
option, which throw an errors when using Rails 7 because that option is defaulted tofalse
My proposal, which I can do if the solution is agreed upon, is to allow the
passwordless
configuration*_redirect_path
setting to take aProc
, in addition to a string. This way the host application could provide a bit more specificity about how a redirection should function.What do you think? Is there a better solution?
The text was updated successfully, but these errors were encountered: