Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with np.float, np.bool, np.complex #105

Open
ad12 opened this issue Feb 6, 2022 · 5 comments
Open

Deprecation warning with np.float, np.bool, np.complex #105

ad12 opened this issue Feb 6, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@ad12
Copy link
Contributor

ad12 commented Feb 6, 2022

Describe the bug
Starting around v1.20, numpy has deprecated generic data types (np.float, np.bool, np.complex) in favor of standard python types (float, bool, complex). This is causing a flurry of deprecation warnings in sigpy, where default types may be any of the generic numpy dtypes.

Recommendation
Set explicit dtypes with explicit precision (e.g. np.float64 instead of np.float)

@ad12 ad12 added the bug Something isn't working label Feb 6, 2022
@sidward
Copy link
Collaborator

sidward commented Jun 1, 2022

In progress #113

@gschramm
Copy link

I saw that this issue was fixed in a commit on Apr 6, but unfortunately the last tagged version that is used to build the conda-forge package is from Apr 3.

When do you plan to release a version that includes the fix?

I am asking, since I am wondering if I should change the conda-forge recipe (req. numpy <=1.19).

@gschramm
Copy link

In progress #113

any updates concerning a new release that includes that PR?

@berkinbilgic
Copy link

I suffered from the same problem, and managed to work around it by installing numpy=1.19.5 in the conda environment.

@henricryden
Copy link

Although numpy officially deprecated np.float etc in 1.20.0, they still didn't really remove it until 1.24. You can use numpy<1.24 in your conda environment until this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants