Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten config keys #7

Open
netpok opened this issue Oct 23, 2019 · 2 comments
Open

Shorten config keys #7

netpok opened this issue Oct 23, 2019 · 2 comments
Assignees
@mikebronner
Labels
enhancement New feature or request

Comments

@netpok
Copy link

netpok commented Oct 23, 2019

All factory included socialite packages are using relatively short keys like GOOGLE_CLIENT_ID, I think it would make reading the config and env easier if this package would use APPLE_CLIENT_ID. The unnecessary (in my opinion) SIGN_IN_WITH_ part just adds visual clutters.
@eliasjtg
Copy link

I think just like you

@mikebronner mikebronner self-assigned this Mar 1, 2020
@mikebronner mikebronner added the enhancement New feature or request label Mar 1, 2020
@mikebronner
Copy link
Owner

@netpok Thanks for the suggestions. I'll consider this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebronner mikebronner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikebronner @netpok @eliasjtg