New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sign In With Apple" didn't return the name #12

Merged

mikebronner merged 1 commit into mikebronner:master from poldixd:patch-1

Mar 1, 2020

Contributor

poldixd commented Mar 1, 2020

This pull request fixed #2. Apple sends the name in the request('user'). Here is an examle what Apple sends:

{"email":"[email protected]","name":{"firstName":"poldixd","lastName":"poldixd"}}

This was always false:

https://github.com/GeneaLabs/laravel-sign-in-with-apple/blob/867204f966c5052fab09df4a469b3dc8348ef368/src/Providers/SigninWithAppleProvider.php#L106-L107


Name is now taken from the request("user")

f47a4f3

Owner

mikebronner commented Mar 1, 2020

@poldixd Thanks for submitting this PR!

mikebronner merged commit f5f7df8 into mikebronner:master

poldixd deleted the patch-1 branch

March 1, 2020 17:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment