Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using as a stateless provider #19

Closed
andreasbergqvist opened this issue Apr 27, 2020 · 1 comment
Closed

Using as a stateless provider #19

andreasbergqvist opened this issue Apr 27, 2020 · 1 comment
Assignees

Comments

@andreasbergqvist
Copy link

andreasbergqvist commented Apr 27, 2020

Hi
We are building an mobile app and would like to use this provider with an Laravel backend.
But have a question.

For Facebook and Google we use:
$socialiteUser = Socialite::driver('facebook')->stateless()->userFromToken($request->token);
Where $request->token is the token sent from the app.

Both the Facebook and the Google provider now runs: getUserByToken() and does an request to verify the user. See:
https://github.com/laravel/socialite/blob/4.0/src/Two/GoogleProvider.php#L61

But in this provider the getUserByToken() function just decodes the token:
https://github.com/GeneaLabs/laravel-sign-in-with-apple/blob/1a2aabe7146ecd0dc7876e49d6891b29203649f7/src/Providers/SignInWithAppleProvider.php#L83

Wouldn't it be a good idea to be consistent with how the other providers work? Or is there something specific with Apple login that works different? Or could this provider still work but call some other function to verify the user?

I understand that this provider is build for the web implementation first but just wanted to raise the question!

Otherwise, great work!

@mikebronner mikebronner self-assigned this Apr 27, 2020
@mikebronner
Copy link
Owner

Hi @andreasbergqvist, thanks for writing in! Apple doesn't work exactly like other OAuth providers. With SIWA you have to request a new token with each login, from what I remember, the token is not stored for reuse.

Repository owner deleted a comment from pnlinh-it Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants