Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: miekg/dns
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.47
Choose a base ref
...
head repository: miekg/dns
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.50
Choose a head ref
  • 17 commits
  • 20 files changed
  • 6 contributors

Commits on Apr 1, 2022

  1. Update SVCB (#1341)

    * Rename ECH, bump draft number
    
    * AliasForm new treatment
    
    * alpn is no longer mandatory by default
    
    * Document the non-empty value requirement
    
    * new test cases
    
    * more test cases
    
    * Continue forbidding v4-map-v6 but not v4-embed-v6
    
    #1067 (comment) and MikeBishop/dns-alt-svc#361
    
    * Update documentation
    
    * revert rename ech
    
    * Reword AliasMode with key=value pairs
    DesWurstes authored Apr 1, 2022
    Configuration menu
    Copy the full SHA
    2f577ca View commit details
    Browse the repository at this point in the history
  2. Invalid NSEC/3 bitmap on non-zero buffer (#1338)

    * Invalid NSEC/3 bitmap on non-zero buffer
    
    If the PackBuffer is used to encode an NSEC/3 record, the bitmap is
    xored with the content of the buffer instead of being zeroed first.
    
    The algorithm has been changed so it is able zero bytes without
    losing too much performance (around 2x slower).
    
    * Add some comments + rename some vars to make algo clearer
    
    * Revert to previous algo with window length compute+0 on new window
    
    * Use typeBitMapLen to compute the bitmap length to zero
    rs authored Apr 1, 2022
    Configuration menu
    Copy the full SHA
    57e2e62 View commit details
    Browse the repository at this point in the history
  3. Fix RSAMD5 keytag calucation. (#1353)

    Of course the wording was changed (for the better) in an errata:
    https://www.rfc-editor.org/errata/eid193
    
    We still followed the original RFC4034 text. Note I haven't given this
    much thought, just changed the 2 into a 3 and ran the test.
    
    Fixes: #1352
    
    Signed-off-by: Miek Gieben <[email protected]>
    miekg authored Apr 1, 2022
    Configuration menu
    Copy the full SHA
    045ac4e View commit details
    Browse the repository at this point in the history
  4. Release 1.1.48

    miekg committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    49c1b2e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2022

  1. Fix ExamplePrivateHandle (#1354)

    Signed-off-by: Miek Gieben <[email protected]>
    miekg authored Apr 2, 2022
    Configuration menu
    Copy the full SHA
    dedee46 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Add SVCB dohpath key (#1359)

    * Add SVCB dohpath key
    
    The parameter is being added in [its own IETF draft][1] and also being used in
    the [IETF draft about Descovery of Designated Resolvers][2].
    
    Additionally, the mappings of the numeric key values to strings are exported,
    under names consistent with the already existing exported mappings, to make it
    easier for the clients of the module to validate and print SVCB keys.
    
    Testing was done by sending SVCB queries for the "_dns.resolver.arpa" domain to
    OpenDNS's 146.112.41.2 server.
    
    [1]: https://datatracker.ietf.org/doc/html/draft-ietf-add-svcb-dns-02
    [2]: https://datatracker.ietf.org/doc/html/draft-ietf-add-ddr-06.html
    
    * Fix template length, docs; reverse some changes
    
    * Remove incorrect validations; improve docs
    ainar-g authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    08c2616 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Add notes about SVCB draft changes to SVCB-related API (#1364)

    * Add notes about SVCB draft changes to SVCB-related API
    
    * Decrease number of warnings, rephrase
    ainar-g authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    656b740 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Fix examples by using net.JoinHostPort (#1368)

    Small fix in the examples to properly work with v6 addresses.
    
    Closes: #1365 #1367
    
    Signed-off-by: Miek Gieben <[email protected]>
    miekg authored Apr 15, 2022
    Configuration menu
    Copy the full SHA
    c760d3c View commit details
    Browse the repository at this point in the history
  2. Upgrade our test Go version to 1.17 and 1.18 (#1369)

    Signed-off-by: Miek Gieben <[email protected]>
    miekg authored Apr 15, 2022
    Configuration menu
    Copy the full SHA
    0d2c95b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Properly parse alpn values in SVCB (#1363)

    * Modify the SVCBAlpn to properly parse/print
    
    * Remove debug
    
    * Change SVCB test from reflect to loop
    
    * Refactor SVCB code to reduce indentation
    
    * When stringifying SVCBAlpn, use strings.Builder for whole process
    
    * Update comment in svcb.go
    
    Co-authored-by: Miek Gieben <[email protected]>
    
    * Describe why we use a specific size for the alpn buffer
    
    Co-authored-by: Miek Gieben <[email protected]>
    shane-ns1 and miekg authored May 10, 2022
    Configuration menu
    Copy the full SHA
    feda877 View commit details
    Browse the repository at this point in the history
  2. Fix dohpath parsing/stringify (#1366)

    * dohpath escaped in String(), and parsed such values
    
    * Update the test for dohpath with escaping
    
    * Fix cut & paste error with svcdohpath error
    shane-ns1 authored May 10, 2022
    Configuration menu
    Copy the full SHA
    bfcbf0f View commit details
    Browse the repository at this point in the history
  3. Release 1.1.49

    miekg committed May 10, 2022
    Configuration menu
    Copy the full SHA
    5521648 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Disallow names that start with '.' in IsDomainName() (#1376)

    * Disallow names that start with '.' in IsDomainName()
    
    * Also update packDomain()
    shane-ns1 authored May 26, 2022
    Configuration menu
    Copy the full SHA
    7413c83 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Add more detail to NSEC packing errors (#1374)

    Add 'in the type bitmap' to make clear where in the RR the error occurs.
    Also use 'NSEC(3)' - as this code is shared between NSEC and NSEC3, the
    first error used NSECx.
    
    Technically backwards incompatible, but checking strings in errors as
    bad practice (although this lib lacks library types).
    
    See #1373
    
    Signed-off-by: Miek Gieben <[email protected]>
    miekg authored May 27, 2022
    Configuration menu
    Copy the full SHA
    eb4745b View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Configuration menu
    Copy the full SHA
    ff611cd View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Make tsigGenerateProvider/TsigVerifyProvider public (#1382)

    Make it public as TsigGenerateWithProvider and update the docs a little.
    And TsigVerifyWithProvider also - tweak those docs also a little.
    
    Signed-off-by: Miek Gieben <[email protected]>
    miekg authored Jun 21, 2022
    Configuration menu
    Copy the full SHA
    69924a0 View commit details
    Browse the repository at this point in the history
  2. Release 1.1.50

    miekg committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b3dfea0 View commit details
    Browse the repository at this point in the history
Loading