Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Request]: ViGEm.HidHide 1.5.230 #160054

Closed
soredake opened this issue Jun 26, 2024 · 3 comments · Fixed by #160057
Closed

[Update Request]: ViGEm.HidHide 1.5.230 #160054

soredake opened this issue Jun 26, 2024 · 3 comments · Fixed by #160057
Labels
Package-Update This package needs to be updated
Milestone

Comments

@soredake
Copy link
Contributor

What type of update are you requesting?

A new version of an existing package

Current Package Identifier

1.5.230

Package Version

1.5.230

Please describe the changes you would like to see

https://github.com/nefarius/HidHide/releases/tag/v1.5.230.0

@soredake soredake added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Jun 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jun 26, 2024
@alyssadev
Copy link

alyssadev commented Jun 27, 2024

The software developer has indicated in the above linked PR that a new package identifier neferius.HidHide should be used instead due to trademark concerns with "ViGEm". Not sure what impact this would have on this update request. Perhaps the process at the linked comment can be followed to update the manifest with the new package identifier for future releases. I'm having trouble parsing the changes made to Tricentis.NeoLoad and am not sure how to replicate them for neferius.HidHide.

Related:
microsoft/winget-cli#4344
#66937 (comment)

@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Jun 27, 2024
@stephengillie
Copy link
Collaborator

I believe all that might be required is to move the manifests. 2 PRs would be needed foreach manifest version:

  • Removal PR to remove the version from ViGEm.HidHide.
  • Addition PR to re-add the version under neferius.HidHide.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Help-Wanted This is a good candidate work item from the community. label Jun 27, 2024
@masterflitzer
Copy link
Contributor

already closed without changing package identifier as mentioned? is this still wanted? if nobody is has started yet i'd volunteer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package-Update This package needs to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants