Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoclose does not detect open state / do not autoclose quotes when in strings #88265

Closed
irvnriir opened this issue Jan 8, 2020 · 11 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Milestone

Comments

@irvnriir
Copy link

irvnriir commented Jan 8, 2020

answer

in VSC, Autoclose entities are not related to {new Scope} triggers, but:

	"autoClosingPairs": [
		<<..>>
		{ "open": "\"", "close": "\"", "notIn": ["string"] }
	]

;

issue

VSC 1.41.1 .

it doesn't detect the open/close state

@connor4312
Copy link
Member

connor4312 commented Jan 8, 2020

It looks like you have an unclosed quote on the first second line v1=%v:". If you fix that, does it work?

/needsMoreInfo

@vscodebot vscodebot bot added the info-needed Issue requires more information from poster label Jan 8, 2020
@vscodebot
Copy link

vscodebot bot commented Jan 8, 2020

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@irvnriir
Copy link
Author

irvnriir commented Jan 8, 2020

@connor4312 , its same when i try to place 3 ` " `, by one, at open space (all 3 times they get doubled)

@connor4312
Copy link
Member

What's the language mode for the opened file? It doesn't look like there's any syntax highlighting, is it getting set correctly?

@irvnriir
Copy link
Author

irvnriir commented Jan 8, 2020

@irvnriir , Batch, working (plain theme)

@connor4312
Copy link
Member

Okay, can you share the contents of the source file from your screenshot so we can try to reproduce it?

@irvnriir
Copy link
Author

irvnriir commented Jan 8, 2020

@connor4312 .

@connor4312
Copy link
Member

Thanks, that's useful!

@connor4312 connor4312 added languages-basic Basic language support issues and removed info-needed Issue requires more information from poster labels Jan 8, 2020
@irvnriir irvnriir changed the title autoclosing quotes configuration work with an issue language configuration issues Jan 8, 2020
@irvnriir
Copy link
Author

irvnriir commented Jan 8, 2020

bat\..\surroundingPairs also doesn't work

@aeschli aeschli changed the title language configuration issues do not autoclose quotes when in strings Jan 9, 2020
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Jan 9, 2020
@aeschli aeschli added this to the January 2020 milestone Jan 9, 2020
@aeschli aeschli closed this as completed in e9bb8b3 Jan 9, 2020
@aeschli
Copy link
Contributor

aeschli commented Jan 9, 2020

Good catch!
Can you file a separate issue for the surroundingPairs issue? Please add a code sample (pasted as text, if possible)

@irvnriir
Copy link
Author

irvnriir commented Jan 9, 2020

@aeschli , is there a command, other than "notIn" (blacklist), to specify a whitelist of Scopes here?

p.s. the surroundingPairs issue

@irvnriir irvnriir changed the title do not autoclose quotes when in strings autoclose does not detect open state / do not autoclose quotes when in strings Jan 9, 2020
@connor4312 connor4312 added the verified Verification succeeded label Jan 30, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants