Should debug integrated terminal support pass the env directly to createTerminal?

[Tyriar]

Looking at this:

vscode/src/vs/workbench/contrib/debug/node/terminals.ts

Lines 113 to 122 in b51019b

	if (args.env) {
	for (let key in args.env) {
	const value = args.env[key];
	if (value === null) {
	command += `Remove-Item env:${key}; `;
	} else {
	command += `\${env:${key}}='${value}'; `;
	}
	}
	}

It looks like it would be a lot simpler to pass in env to createTerminal instead of constructing a per-shell command to set/unset them:

vscode/src/vs/vscode.d.ts

Lines 7106 to 7109 in 4d02d83

	/**
	* Object with environment variables that will be added to the VS Code process.
	*/
	env?: { [key: string]: string | null };

[weinand]

@Tyriar Debug tries to reuse a terminal if it is "free", i.e. if there are no child processes running in it.
So the terminal is created for the first "runInTerminal" and then reused (if possible).
Consequently passing env to createTerminal only works for the first "runInTerminal". Subsequent "runInTerminal" requests still require the current approach.

[weinand]

@Tyriar for addressing this issue I'm trying to use the terminalService.createTerminalFromOptions API. When filling up the option bag, I can use "getDefaultShell". But why is the corresponding "_getDefaultShellArgs" private?

const options: vscode.TerminalOptions = {
	shellPath: this._terminalService.getDefaultShell(configProvider),
	shellArgs: this._terminalService._getDefaultShellArgs(configProvider),
	cwd: args.cwd,
	name: args.title || nls.localize('debug.terminal.title', "debuggee"),
	env: args.env
};
delete args.cwd;
delete args.env;
this._integratedTerminalInstance = this._terminalService.createTerminalFromOptions(options);

[Tyriar]

@weinand it just didn't have any consumers outside yet, whereas the default shell is exposed in the API via env.shell, feel free to change it to public