Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug integrated terminal support doesn't get default terminal #77110

Closed
Tyriar opened this issue Jul 10, 2019 · 1 comment
Closed

Debug integrated terminal support doesn't get default terminal #77110

Tyriar opened this issue Jul 10, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 10, 2019

This is now null by default

const shell_config = config.integrated.shell;
, so the debugger will be often falling back to the system shell instead of the terminal's actual default.

You can call into ITerminalInstanceService.getDefaultShellAndArgs (or getDefaultShell in terminalEnvironment.ts) to get a string now so you don't need to fallback to getSystemShell.

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 10, 2019
@weinand weinand added this to the July 2019 milestone Jul 10, 2019
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Jul 10, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 1, 2019

Verified by making sure variable resolution worked when debugging in integrated terminal "terminal.integrated.shell.linux": "${env:SHELL}"

@Tyriar Tyriar added the verified Verification succeeded label Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants