Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metaKey for iOS #100869

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Support metaKey for iOS #100869

merged 1 commit into from
Jun 24, 2020

Conversation

daybrush
Copy link
Contributor

This PR fixes #70764
coder/code-server#1015

The reason it doesn't work on iPad and iOS is that the OS is not Macintosh.
In the past, the result of the OS on iOS is Linux.
In the revised code, the result of OS in iOS was changed to Macintosh.

@joaomoreno joaomoreno assigned rebornix and unassigned joaomoreno Jun 24, 2020
@rebornix rebornix added this to the June 2020 milestone Jun 24, 2020
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the help!

@rebornix rebornix merged commit 205b0e3 into microsoft:master Jun 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Studio Code for ipad
3 participants